Skip to content

feat(inboxes): make table take all the space and pagination sticky #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChibiBlasphem merged 1 commit into from
Sep 29, 2025
Merged

feat(inboxes): make table take all the space and pagination sticky #1142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/app-builder/src/components/Cases/CasesList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import clsx from 'clsx';
import { differenceInDays } from 'date-fns/differenceInDays';
import { useEffect, useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { Table, Tooltip, useVirtualTable } from 'ui-design-system';
import { Table, Tooltip, useTable } from 'ui-design-system';

import { CaseAssignedTo } from './CaseAssignedTo';
import { CaseContributors } from './CaseContributors';
Expand Down Expand Up @@ -139,7 +139,7 @@ export function CasesList({
[language, t, orgTags],
);

const { table, getBodyProps, rows, getContainerProps, scrollToTop } = useVirtualTable({
const { table, getBodyProps, rows, getContainerProps } = useTable({
data: cases,
columns,
columnResizeMode: 'onChange',
Expand All @@ -151,10 +151,6 @@ export function CasesList({
rowLink: ({ id }) => <Link to={getRoute('/cases/:caseId', { caseId: fromUUIDtoSUUID(id) })} />,
});

useEffect(() => {
scrollToTop();
}, [cases]);

return (
<Table.Container {...getContainerProps()} className={clsx('bg-grey-100', className)}>
<Table.Header headerGroups={table.getHeaderGroups()} />
Expand Down
35 changes: 28 additions & 7 deletions packages/app-builder/src/routes/_builder+/cases+/inboxes.$inboxId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
} from '@app-builder/components/Cases/Filters';
import { InputWithButton } from '@app-builder/components/InputWithButton';
import { useCursorPaginatedFetcher } from '@app-builder/hooks/useCursorPaginatedFetcher';
import useIntersection from '@app-builder/hooks/useIntersection';
import { isForbiddenHttpError, isNotFoundHttpError } from '@app-builder/models';
import { type Case, type CaseStatus, caseStatuses } from '@app-builder/models/cases';
import { type PaginatedResponse, type PaginationParams } from '@app-builder/models/pagination';
Expand All @@ -25,7 +26,7 @@ import { type LoaderFunctionArgs, redirect } from '@remix-run/node';
import { useLoaderData, useNavigate } from '@remix-run/react';
import { type Namespace } from 'i18next';
import qs from 'qs';
import { useCallback } from 'react';
import { useCallback, useEffect, useRef } from 'react';
import { useTranslation } from 'react-i18next';
import { omit } from 'remeda';
import { Button, cn } from 'ui-design-system';
Expand Down Expand Up @@ -212,11 +213,23 @@ export default function Cases() {
[navigate, inboxId, next, previous, reset],
);

const paginationSentinelRef = useRef<HTMLDivElement>(null);
const containerRef = useRef<HTMLDivElement>(null);
const paginationIntersection = useIntersection(paginationSentinelRef, {
root: containerRef.current,
rootMargin: '-24px',
threshold: 0,
});

useEffect(() => {
containerRef.current?.scrollTo({ top: 0 });
}, [cases]);

return (
<CaseRightPanel.Root>
<Page.Container>
<Page.Content>
<div className="flex flex-col gap-4">
<Page.Container ref={containerRef}>
<Page.ContentV2>
<div className="flex flex-col gap-4 relative">
<CasesFiltersProvider submitCasesFilters={navigateCasesList} filterValues={filters}>
<div className="flex justify-between">
<div className="flex gap-4 items-center">
Expand Down Expand Up @@ -262,7 +275,6 @@ export default function Cases() {
<CasesList
key={inboxId}
cases={cases}
className="max-h-[60dvh]"
initSorting={[
{
id: initialPagination.sorting ?? 'created_at',
Expand All @@ -279,7 +291,15 @@ export default function Cases() {
hasAlreadyOrdered = true;
}}
/>
<div className="flex justify-between gap-8">
<div
className={cn(
'flex justify-between gap-8 sticky bottom-0 z-10 bg-purple-99 -mb-v2-lg -mx-v2-lg p-v2-lg pt-v2-md border-t border-purple-99',
{
'shadow-sticky-bottom border-t-grey-95':
!paginationIntersection?.isIntersecting,
},
)}
>
<div className="flex gap-2 items-center">
<span>{t('cases:list.results_per_page')}</span>
{[25, 50, 100].map((limit) => {
Expand Down Expand Up @@ -313,8 +333,9 @@ export default function Cases() {
/>
</div>
</CasesFiltersProvider>
<div ref={paginationSentinelRef} className="absolute left-0 bottom-0" />
</div>
</Page.Content>
</Page.ContentV2>
</Page.Container>
</CaseRightPanel.Root>
);
Expand Down