Skip to content

make ENV, NODE_ENV optional - #1169

Merged
Pascal-Delange merged 1 commit into
mainfrom
pascal/env-changes
Oct 23, 2025
Merged

make ENV, NODE_ENV optional#1169
Pascal-Delange merged 1 commit into
mainfrom
pascal/env-changes

Conversation

@Pascal-Delange

@Pascal-Delange Pascal-Delange commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

No more mandatory, useless environment variables for end users: use reasonable value for production run, opt-in for unsafe development values.

Setting ENV to development changes some logic on toast sending, sentry event sending, and some logic in some (typescript only ???) function called "assertNever"

@Pascal-Delange
Pascal-Delange marked this pull request as ready for review October 23, 2025 07:37

@siiick siiick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Pascal-Delange
Pascal-Delange merged commit b48d3d3 into main Oct 23, 2025
5 checks passed
@Pascal-Delange
Pascal-Delange deleted the pascal/env-changes branch October 23, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants