-
Notifications
You must be signed in to change notification settings - Fork 22
feat(analytics): add DecisionsScoreDistribution #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
302529a
feat(analytics): add DecisionsScoreDistribution
siiick 11021b2
refactor(analytics): change outcome colors
siiick 9dfb480
feat: highlight outcome filters on first Decisions hover
siiick b47d5a0
refactor(analytics): improve Decsions tooltip display
siiick f0cae8c
refactor(analytics): Add a minimum display height for outcomes in Dec…
siiick 9536234
feat(analytics): add tooltips to analytics table headers and componen…
siiick 5ec4f49
cleanup
siiick caab222
fix(Table): change header element from paragraph to div for better st…
siiick 7e5e10e
fix(analytics): update trigger condition to ensure it only applies wh…
siiick 33b085c
feat(analytics): add legacy analytics link to analytics layout
siiick eb392f2
feat(analytics): enable comparison date range selection in analytics …
siiick 23fd073
feat(FiltersBar): add buttons for reapplying and clearing dynamic fil…
siiick 4b6cd84
cleanup
siiick f43f1b8
feat(Decisions): implement scale type toggle
siiick b5dec51
refactor(Decisions): remove minimum display height for outcomes in De…
siiick 2210178
feat(analytics): centralize outcome colors and update imports across …
siiick a3a3cac
feat(analytics): replace TooltipV2 with centralized AnalyticsTooltip …
siiick 680ff3a
feat(Decisions): add scale type labels and conditional rendering for …
siiick 13a68f7
refactor(Decisions): extract utility functions from the component
siiick 646ac8c
feat(FiltersBar): add preset date range options for quick selection i…
siiick 675ed06
refactor(RulesHit): simplify percentage formatting by removing redund…
siiick 33f0ae1
refactor(Analytics): update AnalyticsTooltip usage across components …
siiick 8e49872
refactor(OutcomeFilter): enhance highlight handling with useEffect fo…
siiick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 33 additions & 12 deletions
45
packages/app-builder/src/components/Analytics/OutcomeFilter.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing onMouseLeave handler causes stuck hover state
The
isHoveredstate is set totrueononMouseEnterbut never reset tofalseononMouseLeave. This causes the hover state to persist indefinitely after the user moves their mouse over the component once, preventing the highlight animation from working correctly on subsequent hovers and potentially affecting UI behavior that depends on the hover state.Additional Locations (1)
packages/app-builder/src/components/Analytics/RuleVsDecisionOutcomes.tsx#L84-L90There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional. We want the ping effect only once, the first time the user hover the component.