Skip to content

fix: ast builder not updating value when operator changes MAR-1362 - #1218

Merged
ChibiBlasphem merged 1 commit into
mainfrom
fix/ast-builder-not-updating-value-on-operator-change
Nov 25, 2025
Merged

fix: ast builder not updating value when operator changes MAR-1362#1218
ChibiBlasphem merged 1 commit into
mainfrom
fix/ast-builder-not-updating-value-on-operator-change

Conversation

@ChibiBlasphem

@ChibiBlasphem ChibiBlasphem commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Note

Ensure operator changes in EditionNode trigger a node store update before validation.

  • Ast Builder
    • EditionNode.tsx: In setOperator, after updating the node name and normalizing children for unary/binary operators, call nodeSharp.actions.triggerUpdate() before validate() to propagate the change.

Written by Cursor Bugbot for commit 18af405. This will update automatically on new commits. Configure here.

@ChibiBlasphem
ChibiBlasphem requested a review from a team November 25, 2025 10:47
@linear

linear Bot commented Nov 25, 2025

Copy link
Copy Markdown

@siiick siiick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChibiBlasphem
ChibiBlasphem requested a review from siiick November 25, 2025 12:23
@ChibiBlasphem
ChibiBlasphem merged commit 60460f1 into main Nov 25, 2025
6 checks passed
@ChibiBlasphem
ChibiBlasphem deleted the fix/ast-builder-not-updating-value-on-operator-change branch November 25, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants