Skip to content

collapsible links #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
william-schlegel merged 2 commits into from
Aug 19, 2026
Merged

collapsible links #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94bb0dd
links are in a collapsible so there is more room for the fields when …
william-schlegel Aug 18, 2026
44776cb
fix keyboard nav in collapsible
william-schlegel Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 49 additions & 40 deletions packages/app-builder/src/components/Data/SemanticTables/Shared/LinkForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { linkRelationTypes } from '@app-builder/models';
import { useDataModelFeatureAccess } from '@app-builder/services/data/data-model';
import { useMemo } from 'react';
import { useTranslation } from 'react-i18next';
import { Button, cn, Input, SelectV2, Typo } from 'ui-design-system';
import { Button, Collapsible, cn, Input, SelectV2, Typo } from 'ui-design-system';
import { Icon } from 'ui-icons';
import { DatatypeIcon } from './DatatypeOption';

Expand All @@ -30,47 +30,56 @@ export function LinkForm({
const belongsToFieldNames = belongsToLinks.map((link) => link.tableFieldId).filter(Boolean);

return (
<section className={cn('flex flex-col gap-md rounded-lg', hasError && 'bg-red-primary/5 p-sm')}>
<div className="flex flex-col gap-xs">
<Typo variant="subtitle2">{t('data:upload_data.links_title')}</Typo>
<p className="text-s text-grey-secondary">
{t('data:upload_data.links_description', { tableName: tableLabel })}
</p>
</div>
{belongsToLinks.length > 1 ? (
<Callout color="orange" icon="warning" iconColor="orange">
<span>
{t('data:upload_data.multiple_belongs_to_warning', { tableName: tableLabel })}
{belongsToFieldNames.length > 0
? ` ${t('data:upload_data.multiple_belongs_to_warning_fields', {
fields: belongsToFieldNames.join(', '),
})}`
: null}
</span>
</Callout>
) : null}
<div className="flex flex-col gap-md">
{links.map((link) => (
<LinkRow key={link.linkId} linkId={link.linkId} compact={compact} hasError={errorLinkIds?.has(link.linkId)} />
))}
</div>
{isCreateDataModelLinkAvailable && (
<div className="flex items-center gap-sm">
<Button
variant="primary"
appearance="stroked"
onClick={() => addLink()}
disabled={!destinationTableOptions.length}
>
<Icon icon="plus" className="size-4" />
{t('data:upload_data.link_add')}
</Button>
{!destinationTableOptions.length && (
<span className="text-grey-secondary">{t('data:create_table.link_destination_table_required')}</span>
<Collapsible.Container className={cn('border-none p-0', hasError && 'bg-red-primary/5')} defaultOpen>
<Collapsible.Title size="xs" iconPosition="left">
<button type="button">
<Typo variant="subtitle2">{t('data:upload_data.links_title')}</Typo>
</button>
</Collapsible.Title>
<Collapsible.Content className="border-none" size="xs">
<div className="flex flex-col gap-md">
<p className="text-s text-grey-secondary font-normal">
{t('data:upload_data.links_description', { tableName: tableLabel })}
</p>
{belongsToLinks.length > 1 ? (
<Callout color="orange" icon="warning" iconColor="orange">
<span>
{t('data:upload_data.multiple_belongs_to_warning', { tableName: tableLabel })}
{belongsToFieldNames.length > 0
? ` ${t('data:upload_data.multiple_belongs_to_warning_fields', {
fields: belongsToFieldNames.join(', '),
})}`
: null}
</span>
</Callout>
) : null}
Comment thread
william-schlegel marked this conversation as resolved.
{links.map((link) => (
<LinkRow
key={link.linkId}
linkId={link.linkId}
compact={compact}
hasError={errorLinkIds?.has(link.linkId)}
/>
))}
{isCreateDataModelLinkAvailable && (
<div className="flex items-center gap-sm">
<Button
variant="primary"
appearance="stroked"
onClick={() => addLink()}
disabled={!destinationTableOptions.length}
>
<Icon icon="plus" className="size-4" />
{t('data:upload_data.link_add')}
</Button>
{!destinationTableOptions.length && (
<span className="text-grey-secondary">{t('data:create_table.link_destination_table_required')}</span>
)}
</div>
)}
</div>
)}
</section>
</Collapsible.Content>
</Collapsible.Container>
);
}

Expand Down
Loading
Loading