Skip to content

Add comments feature to MatchCard component - #1835

Open
william-schlegel wants to merge 1 commit into
mainfrom
williamschlegel/mar-2229-note-display-in-the-reviews
Open

Add comments feature to MatchCard component#1835
william-schlegel wants to merge 1 commit into
mainfrom
williamschlegel/mar-2229-note-display-in-the-reviews

Conversation

@william-schlegel

@william-schlegel william-schlegel commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

update openapi with the comments already sent by the /cases/:caseid route

Screenshot 2026-08-27 at 16 17 46

Summary by CodeRabbit

  • New Features

    • Continuous screening match cards now display associated comments beneath their topic tags.
    • Match comments include the author, comment text, identifier, and creation date.
    • Screening match data now consistently includes comments across supported screening results.
  • Documentation

    • Updated screening data definitions to describe the comments included with continuous screening matches.

update openapi with the comments already sent by the `/cases/:caseid` route
@william-schlegel william-schlegel added the 131 Cycle 131 label Aug 27, 2026
@linear-code

linear-code Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

MAR-2229

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 30c334ad-ad72-46e1-8360-05c394806250

📥 Commits

Reviewing files that changed from the base of the PR and between 5c55727 and e280608.

⛔ Files ignored due to path filters (1)
  • packages/marble-api/src/generated/marblecore-api.ts is excluded by !**/generated/**
📒 Files selected for processing (5)
  • packages/app-builder/src/components/CaseManager/ContinuousScreening/MatchCard.tsx
  • packages/app-builder/src/components/Screenings/MatchCard/CommentLine.tsx
  • packages/app-builder/src/models/continuous-screening.ts
  • packages/app-builder/src/models/screening.ts
  • packages/marble-api/openapis/marblecore-api/continuous-screenings.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: check / main
  • GitHub Check: e2e
🧰 Additional context used
📓 Path-based instructions (2)
Use internal imports from `@app-builder` namespace for models, queries, components, and utilities

📄 CodeRabbit inference engine (CLAUDE.md)

Files:

  • packages/app-builder/src/components/CaseManager/ContinuousScreening/MatchCard.tsx
  • packages/app-builder/src/components/Screenings/MatchCard/CommentLine.tsx
  • packages/app-builder/src/models/screening.ts
  • packages/app-builder/src/models/continuous-screening.ts
Use Tailwind CSS 4 with the tailwind-preset package for consistent styling across packages

📄 CodeRabbit inference engine (CLAUDE.md)

Files:

  • packages/app-builder/src/components/CaseManager/ContinuousScreening/MatchCard.tsx
  • packages/app-builder/src/components/Screenings/MatchCard/CommentLine.tsx
  • packages/app-builder/src/models/screening.ts
  • packages/app-builder/src/models/continuous-screening.ts
🔇 Additional comments (5)
packages/marble-api/openapis/marblecore-api/continuous-screenings.yml (1)

895-895: LGTM!

Also applies to: 917-937

packages/app-builder/src/models/screening.ts (1)

199-205: LGTM!

Also applies to: 214-225, 234-234

packages/app-builder/src/models/continuous-screening.ts (1)

26-32: LGTM!

Also applies to: 363-363, 423-452

packages/app-builder/src/components/Screenings/MatchCard/CommentLine.tsx (1)

1-7: LGTM!

packages/app-builder/src/components/CaseManager/ContinuousScreening/MatchCard.tsx (1)

1-1: LGTM!

Also applies to: 58-60


📝 Walkthrough

Walkthrough

Continuous screening match comments are now defined in the API schema, normalized by shared model adapters, and rendered below match topic tags.

Changes

Continuous screening comments

Layer / File(s) Summary
API comment contract
packages/marble-api/openapis/marblecore-api/continuous-screenings.yml
ContinuousScreeningMatchBaseDto now requires comment records with id, author_id, comment, and created_at.
Normalized comment models
packages/app-builder/src/models/screening.ts, packages/app-builder/src/models/continuous-screening.ts
The models now use ScreeningMatchComment[]. Shared adapters normalize API comments and populate continuous screening matches.
Match card comment rendering
packages/app-builder/src/components/Screenings/MatchCard/CommentLine.tsx, packages/app-builder/src/components/CaseManager/ContinuousScreening/MatchCard.tsx
MatchCard renders each screening match comment through CommentLine, keyed by comment ID.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Merge Risk: ⚪ Minimal · up to e2806

The PR displays comments already returned with authorized case data and adds no new access or persistence behavior. No actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant ContinuousScreeningAPI
  participant ModelAdapters
  participant MatchCard
  participant CommentLine
  ContinuousScreeningAPI->>ModelAdapters: return match comments
  ModelAdapters->>ModelAdapters: normalize comment fields
  ModelAdapters->>MatchCard: provide ScreeningMatchComment[]
  MatchCard->>CommentLine: render each comment
Loading

Suggested reviewers: chibiblasphem

Poem

Comments arrive with fields aligned,
Through adapters, cleanly defined.
Match cards show each note in view,
With typed lines rendered true.
The screening trail now speaks anew.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: adding comment display to the MatchCard component. It also remains concise and specific.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch williamschlegel/mar-2229-note-display-in-the-reviews

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

131 Cycle 131

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant