Skip to content

Release 8.5.0 - Airline and accommodation sub-tree model alignment - #615 - #679

Open
david-ruiz-cko wants to merge 1 commit into
masterfrom
release/8.5.0
Open

david-ruiz-cko wants to merge 1 commit into
masterfrom
release/8.5.0

Conversation

@david-ruiz-cko

@david-ruiz-cko david-ruiz-cko commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

This release makes significant improvements to the handling of industry-specific payment data, especially for airline and accommodation information, and enhances documentation and type consistency throughout the SDK. The most important changes include refactoring the Industry entity to correctly map to API specifications, updating data models for airline and accommodation information, and improving code documentation and type safety.

Industry Data Model Refactoring

  • The Industry class now uses IList<AirlineData> and IList<AccommodationData> for Airline and Accommodation properties, respectively, replacing the previous singular object properties. This change ensures correct serialization/deserialization and proper mapping to the API's expected array structure.

Airline and Accommodation Data Model Updates

  • AirlineData and AccommodationData classes are updated with enhanced documentation, correct property types (e.g., IList<Passenger> for passengers), and improved handling of array/single-object deserialization. The AccommodationData class now uses IList for collections and string types for State and Country for better API compatibility. [1] [2]
  • The PaymentContextsAirlineData and related context classes are updated for consistency, including the use of array types, improved documentation, and handling of string-based fields as specified by the API. [1] [2] [3] [4]

Documentation and Specification Alignment

  • Extensive XML documentation comments are added or improved across all affected models, clarifying the purpose, usage, and API mapping for each property. Remarks are included to highlight differences between the SDK and the API specification. [1] [2] [3] [4] [5] [6] [7]

Namespace and File Organization

  • Several files are moved to more specific namespaces (Requests, Responses) for clarity and maintainability, and using directives are updated accordingly. [1] [2] [3] [4] [5] [6] [7]

Type and Serialization Improvements

  • List properties are consistently typed as IList<T> instead of List<T>, and custom JSON converters are used where the API may return either a single object or an array, ensuring robust (de)serialization. [1] [2] [3]

These changes collectively improve the SDK’s alignment with the API, enhance type safety, and provide clearer documentation for developers.

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 29, 2026 15:35
@agent-wall-e

agent-wall-e Bot commented Sep 29, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Sep 29, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Sep 29, 2026

Copy link
Copy Markdown

🟠 Advisory review: Concerns worth a look

This PR needs a human approval. Before you give it, these are the things I'd want resolved.

The diff only shows a version bump from 8.4.0 to 8.5.0 in gradle.properties, but the PR description exclusively describes C#-specific changes (IList, XML doc comments, using directives, namespaces) that do not belong in a Java SDK — this is either a truncated diff missing the actual Java changes, or the description was copy-pasted from a C# SDK PR.

Concerns

  • The provided diff contains only the gradle.properties version bump; all substantive changes described in the PR body are absent from the diff, making it impossible to verify the claimed improvements.
  • The PR description references C#-specific constructs (IList, XML summary/remarks tags, 'using directives') that have no equivalent in Java, strongly suggesting the description was copied from a different SDK's PR and does not describe the actual changes in this repository.
  • If this diff is complete and the only change is the version bump, releasing 8.5.0 with no code changes is misleading and the version increment is unjustified.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant