feat: add edit subcommand#205
Open
ImranullahKhann wants to merge 2 commits intocheckpoint-restore:mainfrom
Open
feat: add edit subcommand#205ImranullahKhann wants to merge 2 commits intocheckpoint-restore:mainfrom
ImranullahKhann wants to merge 2 commits intocheckpoint-restore:mainfrom
Conversation
Binary Size Check FailedThe binary size increase exceeds the allowed threshold. Size Check OutputHow to resolveIf this size increase is expected and acceptable, a maintainer can add Binary size check performed by CI |
Contributor
Author
|
I have tested the functionality on Podman and CRI-O checkpoints. I will start working on writing the tests and would appreciate any feedback and guidance. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 79.98% 77.84% -2.15%
==========================================
Files 16 19 +3
Lines 1759 2040 +281
==========================================
+ Hits 1407 1588 +181
- Misses 263 328 +65
- Partials 89 124 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@rst0git, please take a look |
Member
|
Please take a look at providing unit tests and end to end tests. |
ImranullahKhann
force-pushed
the
main
branch
2 times, most recently
from
e536151 to
1c8ceeb
Compare
Contributor
Author
|
@adrianreber, please have a look |
Member
|
Try to add more unit tests. Especially the error branches are not covered well. |
Currently only supports tcp listen port remapping. Made the following changes: - Added the edit command in cmd/. - Added edit_archive.go in internals/ for the main edit logic. - Added archive_modifiers.go inside internals/. It contains the modifier logic for any entry that would need changes in the archive. Kept extensibility in mind, for any additional change logic in the future, we can reuse the same function tarStreamRewrite (in edit_archive.go) and write additional modifier functions in archive_modifiers.go. Assisted-by: Github Copilot Signed-off-by: Imranullah Khan <imranullahkhann2004@gmail.com>
Signed-off-by: Imranullah Khan <imranullahkhann2004@gmail.com>
Contributor
Author
|
Please have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only supports tcp listen port remapping. Made the following changes:
Kept extensibility in mind, for any additional edit logic in the future, we can reuse the same function tarStreamRewrite (in edit_archive.go) and write additional modifier functions in archive_modifiers.go.
Closes #169