add missing diff socket logic#210
Open
hxadogar wants to merge 3 commits intocheckpoint-restore:mainfrom
Open
Conversation
Signed-off-by: Hamza Dogar <hxadogar@gmail.com>
Member
|
Please add the tests to this PR as a second commit. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 16 16
Lines 1759 1854 +95
=======================================
+ Hits 1407 1483 +76
- Misses 263 281 +18
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
of course, will add tests shortly. for now here is my manual testing output: |
Signed-off-by: Hamza Dogar <hxadogar@gmail.com>
Author
|
i have added bats tests and i think its ready for review |
Member
|
Thanks. Also add a couple of unit tests, especially for the error cases which are not covered via bats tests. |
Signed-off-by: Hamza Dogar <hxadogar@gmail.com>
Author
|
i added the unit tests and try to covered the error cases too (not too much) you can take another look when you get time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff
--socketswas registered but not actually any compared logic.now shows sockets added or removed.
it handles all socket types.
i have tested and verified manually.
and i will try to follow up with a dedicated pr for tests.