Add global configuration file support #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behouba
force-pushed
the
feat/global-config-support
branch
2 times, most recently
from
5154e30 to
501222b
Compare
This commit centralizes client specific feature and cleans up the main application entry point. Signed-off-by: Kouame Behouba Manasse <behouba@gmail.com>
behouba
force-pushed
the
feat/global-config-support
branch
2 times, most recently
from
0be9125 to
c6c85d6
Compare
Prior to this commit, users had to create a separate configuration file for
each process involved in the coordinated checkpoint. This commit
enables the usage of a single config file for multiple processes. The
global config should be stored inside `/etc/criu/criu-coordinator.json`
and it uses a slightly different format from the per-process config.
Example of global config:
```json
{
"address": "127.0.0.1",
"port": "8080",
"log-file": "/var/log/criu-coordinator.log",
"dependencies": {
"A": ["B", "C"],
"B": ["C", "A"],
"C": ["A"]
}
}
```
Where `dependencies` field is a map of IDs (e.g: container IDs) to a list of dependencies.
Signed-off-by: Kouame Behouba Manasse <behouba@gmail.com>
Signed-off-by: Kouame Behouba Manasse <behouba@gmail.com>
behouba
force-pushed
the
feat/global-config-support
branch
2 times, most recently
from
b9b980b to
fed78da
Compare
Member
|
@behouba Thanks! This is very useful change. I will review the patches later this week. |
Draft
Member
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for global configuration file. Before, users had to create a separate configuration file for each process involved in the coordinated checkpoint. This PR enables the usage of a single config file for multiple processes. The global config should be stored inside
/etc/criu/criu-coordinator.jsonand it uses a slightly different format from the per-process config.Example of global config:
{ "address": "127.0.0.1", "port": "8080", "log-file": "/var/log/criu-coordinator.log", "dependencies": { "A": ["B", "C"], "B": ["C", "A"], "C": ["A"] } }