Support for type names with the full package path#73
Open
jamesrr39 wants to merge 2 commits intocheekybits:masterfrom
Open
Support for type names with the full package path#73jamesrr39 wants to merge 2 commits intocheekybits:masterfrom
jamesrr39 wants to merge 2 commits intocheekybits:masterfrom
Conversation
jamesrr39
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for types that require package imports (i.e. the type will not sit in the same package as the generate code), for example
genny gen "ValueType=example.com/a/b.MyType".My first PR in this repo, please give feedback as appropriate! In accordance with the readme file, I've read the godoc for the
parsepackage and this PR doesn't break or change any of that, and I've added tests for the new methods.