fix(attributes): lowercase attribute name before lookup in getAttr and setAttr#5256
Open
chu0119 wants to merge 1 commit into
Open
fix(attributes): lowercase attribute name before lookup in getAttr and setAttr#5256chu0119 wants to merge 1 commit into
chu0119 wants to merge 1 commit into
Conversation
…tAttr HTML attribute names are case-insensitive, but cheerio's internal attribs object stores them in lowercase (from htmlparser2). When a user passes an uppercase attribute name like `CLASS`, the lookup fails because the key is stored as `class`. This change lowercases the attribute name in getAttr before looking up in elem.attribs, and in setAttr before storing, matching jQuery's behavior for HTML documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
.attr()to handle case-insensitive attribute name lookup, matching HTML specification and jQuery behavior.Why
HTML attribute names are case-insensitive per the spec. htmlparser2 stores all attribute names in lowercase within the internal
attribsobject. When a user passes an uppercase attribute name (e.g.,$el.attr('CLASS')), the lookup fails because the stored key isclass.What changed
getAttr: Lowercase the attribute name before looking it up inelem.attribs, and in the option/checkbox value fallback comparisonssetAttr: Lowercase the attribute name before storing, maintaining consistency with htmlparser2's lowercase storageTest plan
valid attr should be case-insensitive for HTML documentsadded