Update google.golang.org/grpc to v1.79.3 - #274
Merged
Merged
Conversation
- Update grpc dependency from v1.29.0 to v1.79.3 in go.mod - Remove storage/etcd backend (incompatible with grpc v1.30+ due to removed grpc/naming package) - Remove etcd import and storage entry from cmd/dex/config.go - Run go mod tidy to update go.sum Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
Aishwarya2001A
force-pushed
the
update-grpc-v1.79.3
branch
from
May 15, 2026 09:01
dd65b3f to
b624f76
Compare
Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
…_SOURCE Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
Migrate from the old monolithic go.etcd.io/etcd module (which depended on google.golang.org/grpc/naming, removed in grpc v1.30.0) to the modern modular go.etcd.io/etcd/client/v3 v3.5.21. Changes: - storage/etcd/: restored all 4 files with updated import paths - go.etcd.io/etcd/clientv3 -> go.etcd.io/etcd/client/v3 - go.etcd.io/etcd/clientv3/namespace -> go.etcd.io/etcd/client/v3/namespace - go.etcd.io/etcd/pkg/transport -> go.etcd.io/etcd/client/pkg/v3/transport - cmd/dex/config.go: restored etcd storage registration - go.mod: added go.etcd.io/etcd/client/v3 and client/pkg/v3 v3.5.21 - .github/workflows/ci.yml: update etcd image to v3.5.21, add DEX_ETCD_ENDPOINTS env var Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
etcdctl is not bundled in gcr.io/etcd-development/etcd:v3.5.21 image. Switch health check to use curl against the /health HTTP endpoint. Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
…velopment/etcd image) Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
v3.2.9 was the original working image with a compatible etcdctl health check. The etcd client/v3 Go module is still v3.5.21 — the CI image version does not need to match the Go module version. Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
Signed-off-by: Aishwarya2001A <aaishwar@progress.com>
| steps: | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v1 | ||
| uses: actions/setup-go@v5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
google.golang.org/grpcto v1.79.3Bumps gRPC from
v1.29.0tov1.79.3to align withchef/automate-private.Changed Files (9)
go.modgoogle.golang.org/grpctov1.79.3in bothrequireandreplacedirectivesgo.etcd.io/etcd/client/v3 v3.5.21andgo.etcd.io/etcd/client/pkg/v3 v3.5.21— modern modular etcd client, compatible with grpc v1.79.3go.etcd.io/etcdwhich depended ongrpc/naming(removed in grpc v1.30.0)go.sumstorage/etcd/config.gogo.etcd.io/etcd/clientv3→go.etcd.io/etcd/client/v3go.etcd.io/etcd/clientv3/namespace→go.etcd.io/etcd/client/v3/namespacego.etcd.io/etcd/pkg/transport→go.etcd.io/etcd/client/pkg/v3/transportstorage/etcd/etcd.gogo.etcd.io/etcd/clientv3→go.etcd.io/etcd/client/v3storage/etcd/etcd_test.gogo.etcd.io/etcd/clientv3→go.etcd.io/etcd/client/v3storage/etcd/types.goKeysstruct fields (no logic change)cmd/dex/config.go(not in diff — restored inline with etcd files)etcdstorage registration in thestoragesmapserver/api_test.gogrpc.Dial+grpc.WithInsecure()withgrpc.NewClient+insecure.NewCredentials()Dockerfilegolang:1.15.6-alpine3.12→golang:1.24-alpine3.21alpine:3.12→alpine:3.21CGO_CFLAGS="-D_LARGEFILE64_SOURCE"to fix sqlite3 CGO build on Alpine musl-libc.github/workflows/ci.ymlactions/setup-gofromv1→v5(required: Node.js 16 deprecated on GitHub runners)gcr.io/etcd-development/etcd:v3.2.9(original working version)DEX_ETCD_ENDPOINTSenv var to the test run step