Cookstyle Bot Auto Corrections with Cookstyle 7.30.1 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client. ### Chef/Style/CommentFormat - **/Rakefile:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/helpers.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) ### Style/RegexpLiteral - **/attributes/aws.rb:6**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) ### Layout/ClosingParenthesisIndentation - **/attributes/aws.rb:75**: Indent `)` to column 3 (not 4) ### Chef/Modernize/DatabagHelpers - **/attributes/azure.rb:18**: Use the `data_bag_item` helper instead of `Chef::DataBagItem.load` or `Chef::EncryptedDataBagItem.load`. (https://docs.chef.io/workstation/cookstyle/chef_modernize_databaghelpers) ### Style/TrailingCommaInHashLiteral - **/attributes/gce.rb:28**: Put a comma after the last item of a multiline hash. ### Layout/IndentationWidth - **/libraries/helpers.rb:42**: Use 2 (not 4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) ### Layout/IndentationStyle - **/libraries/helpers.rb:44**: Tab detected in indentation. (https://rubystyle.guide#spaces-indentation) ### Style/TrailingCommaInArrayLiteral - **/libraries/helpers.rb:44**: Put a comma after the last item of a multiline array. (https://rubystyle.guide#no-trailing-array-commas) - **/libraries/helpers.rb:71**: Put a comma after the last item of a multiline array. (https://rubystyle.guide#no-trailing-array-commas) ### Chef/Correctness/IncorrectLibraryInjection - **/libraries/helpers.rb:135**: Libraries should be injected into the Chef::DSL::Recipe class and not Chef::Recipe or Chef::Provider classes directly. (https://docs.chef.io/workstation/cookstyle/chef_correctness_incorrectlibraryinjection) - **/libraries/helpers.rb:136**: Libraries should be injected into the Chef::DSL::Recipe class and not Chef::Recipe or Chef::Provider classes directly. (https://docs.chef.io/workstation/cookstyle/chef_correctness_incorrectlibraryinjection) ### Chef/Sharing/InvalidLicenseString - **/metadata.rb:5**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring) ### Chef/RedundantCode/LongDescriptionMetadata - **/metadata.rb:7**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) ### Chef/Style/UsePlatformHelpers - **/recipes/_packer.rb:4**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/recipes/_packer.rb:10**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) Signed-off-by: Cookstyle <[email protected]>
Author
|
Closing this pull request as it has been superseded by #55, which was created with Cookstyle 7.31.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.
Chef/Style/CommentFormat
Style/RegexpLiteral
%raround regular expression. (https://rubystyle.guide#percent-r)Layout/ClosingParenthesisIndentation
)to column 3 (not 4)Chef/Modernize/DatabagHelpers
data_bag_itemhelper instead ofChef::DataBagItem.loadorChef::EncryptedDataBagItem.load. (https://docs.chef.io/workstation/cookstyle/chef_modernize_databaghelpers)Style/TrailingCommaInHashLiteral
Layout/IndentationWidth
Layout/IndentationStyle
Style/TrailingCommaInArrayLiteral
Chef/Correctness/IncorrectLibraryInjection
Chef/Sharing/InvalidLicenseString
Chef/RedundantCode/LongDescriptionMetadata
Chef/Style/UsePlatformHelpers
Signed-off-by: Cookstyle [email protected]