[WIP] Only depend on aws-sdk-marketplacemetering and update omnibus gem#127
Open
jeremiahsnapp wants to merge 1 commit into
Open
[WIP] Only depend on aws-sdk-marketplacemetering and update omnibus gem#127jeremiahsnapp wants to merge 1 commit into
jeremiahsnapp wants to merge 1 commit into
Conversation
A new omnibus gem was recently released that fixes a bug in the omnibus buildkite pipelines which requires updating the omnibus gem in this repo's Gemfile.lock file. However, the current Gemfile depends on an old version of aws-sdk which conflicts with the omnibus' use of the newer aws-sdk version that breaks aws-sdk into individual gems to enable user's to avoid depending on hundreds of unnecessary aws-sdk gems. It looks like omnibus-marketplace reckoner only needs the aws-sdk-marketplacemetering gem. Signed-off-by: Jeremiah Snapp <jeremiah@chef.io>
Contributor
Author
|
More commits need to be added to this PR by an omnibus-marketplace developer to ensure that the project's code actually uses the |
jeremiahsnapp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new omnibus gem was recently released that fixes a bug in the omnibus buildkite pipelines which requires updating the omnibus gem in this repo's Gemfile.lock file. However, the current Gemfile has
gem "aws-sdk", "~> 2"which conflicts with the omnibus' use of the neweraws-sdkversion that breaks aws-sdk into individual gems to enable user's to avoid depending on hundreds of unnecessary aws-sdk gems. It looks likeomnibus-marketplacereckoneronly needsthe
aws-sdk-marketplacemeteringso this PR replaces the dependency onaws-sdkwithaws-sdk-marketplacemetering.