You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acitvesupport is being a nightmare to manage. It has been removed from Chef Zero and Chef 19. We are trying to get rid of it across the board. In removing it from oc-chef-pedant we also noted a dependency on the chef-18 chef client. It was added solely to extract the chef version number. Why? That brought in an incredible amount of overhead and dependencies that we had no need for. This PR updates the KNIFE_VERSION constant to a known shipping chef-client version. The code had previously hard-coded a chef version in the gemfile so we just moved that version over to the request.rb file. Removing activesupport also had an effect on various other files since the code was actively using that gem. This was going to create a huge problem in chef-19, and chef-zero since they do NOT use activesupport. We updated things to replace the features that activesupport was providing. Finally, we also added a spec_helper and a readme so that users could test various spec files locally. Normally, you'd need a whole chef-server to run spec tests against but with the spec_helper you can bypass that for some of the tests. Anything that makes an HTTP request is going to fail but this helps.
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
I talked to Marc Paradise about this and he advised me to do a full 'bundle update' on oc-chef-pedant, although that has nothing to do with most of the failures. However, in doing that, I encountered an error with unf_ext saying version 0.0.8.2 was not compatible with Ruby 3.4. That IS a problem given that we are all headed to Ruby 3.4 so I am starting work on updating that. Can someone take a look at the chef-server specific failures though?
@kalroy can someone from server team help out with the server specific failures? This is blocking the chef 19 RC3.
Updating this - I have resolved everything but the server hab package issues. Can someone take a look? Also, we're putting the issue of support for Ruby 3.4 into another PR later.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Acitvesupport is being a nightmare to manage. It has been removed from Chef Zero and Chef 19. We are trying to get rid of it across the board. In removing it from oc-chef-pedant we also noted a dependency on the chef-18 chef client. It was added solely to extract the chef version number. Why? That brought in an incredible amount of overhead and dependencies that we had no need for. This PR updates the KNIFE_VERSION constant to a known shipping chef-client version. The code had previously hard-coded a chef version in the gemfile so we just moved that version over to the request.rb file. Removing activesupport also had an effect on various other files since the code was actively using that gem. This was going to create a huge problem in chef-19, and chef-zero since they do NOT use activesupport. We updated things to replace the features that activesupport was providing. Finally, we also added a spec_helper and a readme so that users could test various spec files locally. Normally, you'd need a whole chef-server to run spec tests against but with the spec_helper you can bypass that for some of the tests. Anything that makes an HTTP request is going to fail but this helps.
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List