Drop chef gem dependency from oc-chef-pedant #4122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-server processing.
|
neha-p6
force-pushed
the
neha-p6/remove_activesupport
branch
5 times, most recently
from
552bbd7 to
59d15c5
Compare
…s dependency, add activesupport as direct dependency which used to pulled in via chef since it is widely using concern implementation Signed-off-by: neha-p6 <[email protected]>
neha-p6
force-pushed
the
neha-p6/remove_activesupport
branch
from
3b29270 to
07a733a
Compare
|
|
Collaborator
Author
|
Verify https://buildkite.com/chef/chef-chef-server-main-verify/builds/12292 Errors in verify pipeline are also being seen on main adhoc https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/7847 |
neha-p6
changed the title
5 tasks
Contributor
sreepuramsudheer
approved these changes
Nov 19, 2025
Contributor
sreepuramsudheer
left a comment
sreepuramsudheer
left a comment
There was a problem hiding this comment.
Looks good to me.
jashaik
reviewed
Nov 20, 2025
jashaik
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
chefgem fromoc-chef-pedantGemfile as the only reason chef gem was being used is to get KNIFE::VERSION via chef version but this ended up pulling entire chef dependency chain just get version number of chef (which was anyway hardcoded in Gemfile) did not make sense. This also ended up causing a circular dependency between chef -> chef-zero -> oc-chef-pedant also pulling chef18 in chef19 via oc-chef-pedant. So we will remove the chef gem dependency from here, getting rid of all the nested dependencies.Removing chef gem will also remove
activesupportdependency fromoc-chef-pedant. Butoc-chef-pedantinternally is usingactivesupport/concerta lot in specs, even though activesupport was not a direct dependency for it. So we will addactivesupportas direct dependency of oc-chef-pedant so that specs continue to work. Later on team can look into getting rid of activesupport which requires modifications to specs as activesupport/concert implementation will need to be replaced.Pull chef-zero from github main branch instead of gem since there are fixes in there which are not released yet so that pipelines here continue to work
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List