Skip to content

Conversation

@ashiqueps
Copy link

Description

This PR will remove the licensing changes introduced for the chef-infra-client 19 which includes the following.

  • Removed the kitchen license commands
  • Enforcing the license for the kitchen converge and kitchen verify commands.
  • Passing the license key to the created node to activate it there.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps ashiqueps requested review from a team as code owners June 10, 2025 11:13
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps ashiqueps marked this pull request as draft June 10, 2025 14:14
@Stromweld
Copy link

I don't think we should remove any of this as it will still be needed for downloads of the chef-client from the commercial api after omnitruck website is shutdown and a license_key is still needed to download the client for a test-kitchen run.

@Stromweld
Copy link

see my work on #52 to add support for client downloads from commercial api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants