Adding knife-vcenter to the knife hab pkg - #198
Open
ashiqueps wants to merge 3 commits into
Open
Conversation
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
ashiqueps
force-pushed
the
CHEF-32143-integrate-knife-vcenter
branch
from
August 18, 2026 13:55
69b35d2 to
72aba4d
Compare
The verify pipeline installs the full Gemfile, including the 'habitat' group (knife-ec2, knife-google, knife-windows, knife-vcenter), before running 'rake spec'. Those gems are only needed for Habitat packaging, which is validated by a separate pipeline that never invokes this script; 'rake spec' does not exercise them. Installing knife-vcenter pulls in rbvmomi -> nokogiri, and nokogiri's precompiled native gem requires a newer glibc than Rocky Linux 8 / RHEL 8 (glibc 2.28) provides, causing: /lib64/libm.so.6: version `GLIBC_2.29' not found (required by .../nokogiri.so) Excluding the 'habitat' bundler group for spec runs avoids installing nokogiri altogether, fixing the failure without needing to compile native extensions from source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Knife’s Habitat packaging inputs to include the knife-vcenter plugin and extends the Habitat package tests to assert the plugin is loadable via the packaged knife executable. It also adjusts the Linux CI test install step to avoid pulling Habitat-only plugin dependencies during rake spec runs.
Changes:
- Add
knife-vcenterto the:habitatBundler group so it is included in Habitat builds. - Extend Habitat test scripts (bash + PowerShell) to verify
knife vcenteris available in the built package. - Skip installing the
:habitatBundler group in.expeditor/run_linux_tests.shto avoid nokogiri/glibc issues on Rocky/RHEL 8 CI images.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
habitat/tests/test.sh |
Adds a vcenter plugin availability check to the Linux Habitat package test. |
habitat/tests/test.ps1 |
Adds a vcenter plugin availability check to the Windows Habitat package test. |
Gemfile.lock |
Locks knife-vcenter and its dependencies for packaging, but needs a version alignment fix for the local knife path gem entry. |
Gemfile |
Adds knife-vcenter to the :habitat group for Habitat packaging. |
.expeditor/run_linux_tests.sh |
Excludes the :habitat group during CI spec/style installs to prevent platform-specific native gem failures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| gem "knife-ec2", "~> 2.2.0" | ||
| gem "knife-google", "~> 5.0.15" | ||
| gem "knife-windows", "~> 5.0.7" | ||
| gem "knife-vcenter", "~>5.0", ">= 5.1.1" |
| # Installing them here unnecessarily pulls in knife-vcenter's rbvmomi -> | ||
| # nokogiri dependency chain, whose precompiled native gem requires a newer | ||
| # glibc than Rocky Linux 8 / RHEL 8 (glibc 2.28) ships, causing: | ||
| # GLIBC_2.29' not found (required by .../nokogiri.so) |
nikhil2611
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the knife-vcenter gem to the knife habitat package with tests checking the loadability
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.