Skip to content

Add a small quality-of-life change for tests #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deriamis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a small quality-of-life change for tests #1147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fa105e
Add a small quality-of-life change for tests
deriamis Feb 29, 2024
a171e32
oops
deriamis Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions spec/unit/library_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ def generate_software(name, version, dependencies = [])
end

it "returns an array of software descriptions, with all top level deps first" do
expect(library.build_order).to eq([
expect(library.build_order.map(&:name)).to eq([
preparation,
erlang,
postgresql,
skitch,
ruby,
erchef,
chef,
])
].map(&:name))
end

context "with a complex dep tree" do
Expand All @@ -113,7 +113,7 @@ def generate_software(name, version, dependencies = [])
end

it "returns an array of software descriptions, with all top level deps first, assuming they are not themselves transitive deps" do
expect(library.build_order).to eql(
expect(library.build_order(&:name)).to eql(
Copy link
Contributor

@tpowell-progress tpowell-progress Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deriamis should that be build_order.map(&:name) again, or am I missing something?

Copy link
Author

@deriamis deriamis Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you aren't missing anything. I am 🤡.

This is something I was moving over from something else I was doing, and I couldn't just cherry-pick it because it was part of something larger. Looks like I missed a couple of details. I'll push up a fix.

[
preparation, # first
erlang, # via erchef project
Expand All @@ -125,8 +125,7 @@ def generate_software(name, version, dependencies = [])
erchef, # project dep
chef, # project dep
chefdk, # project dep
]
)
].map(&:name))
end
end
end
Expand Down