tests: remove dead code and add a test case#71
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 88.66% 89.21% +0.54%
==========================================
Files 48 48
Lines 450 445 -5
Branches 123 121 -2
==========================================
- Hits 399 397 -2
+ Misses 51 48 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
targos
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed like untested code was trying to read a secondary optional part when the document number was already spreading to the optional part.
However, the code could not work because the condition on the check digit being
<was not done on the check digit but another longer range of characters.I haven't found anywhere that the case is even possible in an authentic document, so I removed it.
The test case added is similar to another example, but I liked that it comes from PRADO so I added it anyway. It already passed before the change.