Skip to content

fix: check digit position when it is not valid#74

Merged
stropitek merged 2 commits intomainfrom
72-document-check-digit-field-issues
Mar 11, 2026
Merged

fix: check digit position when it is not valid#74
stropitek merged 2 commits intomainfrom
72-document-check-digit-field-issues

Conversation

@stropitek
Copy link
Contributor

@stropitek stropitek commented Mar 10, 2026

  • tests: clarify TD1 with document number check digit in optional part
  • fix: ensure start and end of check digit is correct in field details

Closes: #72

Add tests, references, and clarify in comments.

Expected check digit error based on document number input without the '<' character
@stropitek stropitek linked an issue Mar 10, 2026 that may be closed by this pull request
@stropitek stropitek force-pushed the 72-document-check-digit-field-issues branch from 5f3fdf1 to adfcbd9 Compare March 10, 2026 15:29
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (8d0aa52) to head (d2935d3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parsers/parsePersonalNumberCheckDigit.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   89.35%   89.45%   +0.09%     
==========================================
  Files          48       48              
  Lines         451      455       +4     
  Branches      122      126       +4     
==========================================
+ Hits          403      407       +4     
  Misses         48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stropitek stropitek force-pushed the 72-document-check-digit-field-issues branch from adfcbd9 to d2935d3 Compare March 10, 2026 15:33
@stropitek stropitek requested a review from targos March 10, 2026 15:35
@stropitek stropitek merged commit 06eb7be into main Mar 11, 2026
11 checks passed
@stropitek stropitek deleted the 72-document-check-digit-field-issues branch March 11, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document check digit field issues

2 participants