Skip to content

feat(CanvasEditor): add isDestroyed getter #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 1 commit into from
Apr 11, 2025
Merged

feat(CanvasEditor): add isDestroyed getter #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/canvas_editor/init/canvas_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,18 @@ function initCanvasEditor(
this.#destroy = null;
}

get isDestroyed() {
return !this.#editorArea;
}

moleculeChanged() {
this.#checkNotDestroyed();

this.#editorArea.moleculeChanged();
}

#checkNotDestroyed() {
if (!this.#editorArea) {
if (this.isDestroyed) {
throw new Error('CanvasEditor has been destroyed');
}
}
Expand Down
5 changes: 5 additions & 0 deletions types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3572,7 +3572,7 @@

// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface IForceFieldMMFF94Options {
// TODO

Check warning on line 3575 in types.d.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected 'todo' comment: 'TODO'
}

export interface IForceFieldMinimiseOptions {
Expand Down Expand Up @@ -3883,6 +3883,11 @@
* All methods will throw an error after calling this.
*/
destroy(): void;

/**
* Returns whether the editor has been destroyed.
*/
get isDestroyed(): boolean;
}

interface CanvasEditorElementModeEnum {
Expand Down
Loading