Skip to content

Improve dialogs#347

Merged
targos merged 5 commits intomainfrom
dialog-callback
Nov 6, 2025
Merged

Improve dialogs#347
targos merged 5 commits intomainfrom
dialog-callback

Conversation

@targos
Copy link
Member

@targos targos commented Nov 6, 2025

  • fix(canvas_editor): use asynchronous dialog callbacks
  • feat(canvas_editor): allow to submit dialog forms
  • chore: implement ComboBox#setEditable
  • chore: use module proxy for examples

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2025

Deploying openchemlib-js with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90e02aa
Status: ✅  Deploy successful!
Preview URL: https://6de3a931.openchemlib-js.pages.dev
Branch Preview URL: https://dialog-callback.openchemlib-js.pages.dev

View logs

This allows to remove a hack that resulted in superfluous update events.
They should behave more intuitively now, we can press enter in input fields to submit.
Unused currently but will be needed if we add drawing objects to the editor.
Allows simple swapping of the OCL library for testing/debugging.
@targos targos merged commit a1c275e into main Nov 6, 2025
6 checks passed
@targos targos deleted the dialog-callback branch November 6, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant