Skip to content

strimzi-kafka-cli 1.0.0b2 - #9933

Open
chenrui333 wants to merge 1 commit into
mainfrom
bump-strimzi-kafka-cli-1.0.0b2
Open

strimzi-kafka-cli 1.0.0b2#9933
chenrui333 wants to merge 1 commit into
mainfrom
bump-strimzi-kafka-cli-1.0.0b2

Conversation

@chenrui333

Copy link
Copy Markdown
Owner

Created by brew bump


Created with brew bump-formula-pr.

Copilot AI lite review requested due to automatic review settings August 5, 2026 23:29
@github-actions github-actions Bot added the python Python use is a significant feature of the PR or issue label Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the strimzi-kafka-cli Homebrew formula to the 1.0.0b2 PyPI release, refreshing the source tarball checksum and adjusting the vendored Python resources to match the new upstream dependency set.

Changes:

  • Bump strimzi-kafka-cli from 0.1.0a79 to 1.0.0b2 (url/sha256).
  • Refresh Python resources (add/remove/update vendored packages such as cffi, cryptography, and version bumps for common deps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 40 to +44

resource "cryptography" do
url "https://files.pythonhosted.org/packages/de/41/6cbdcf9142d00fe82836fbb51e503e58088575cf7a0fe1dbff6695bf0840/cryptography-50.0.0.tar.gz"
sha256 "eeac2acb5a20ed25e0ad6d1df9891a520b78b404266b6d11778f25d5d691a6c9"
end

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e50d3ad6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +41 to +43
resource "cryptography" do
url "https://files.pythonhosted.org/packages/de/41/6cbdcf9142d00fe82836fbb51e503e58088575cf7a0fe1dbff6695bf0840/cryptography-50.0.0.tar.gz"
sha256 "eeac2acb5a20ed25e0ad6d1df9891a520b78b404266b6d11778f25d5d691a6c9"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a buildable cryptography dependency

On clean Homebrew builders, virtualenv_install_with_resources now builds this newly vendored cryptography 50 sdist from source, but the formula declares neither the Rust toolchain required by its maturin build nor Homebrew's shared cryptography formula, so installation stops when cargo/rustc is unavailable. Replace the resource with depends_on "cryptography" => :no_linkage and exclude it from pypi_packages, or at minimum add the required Rust build dependency.

AGENTS.md reference: AGENTS.md:L162-L162

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants