strimzi-kafka-cli 1.0.0b3 - #9949
Conversation
github-actions
Bot
added
the
python
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac095bc15a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| resource "cryptography" do | ||
| url "https://files.pythonhosted.org/packages/de/41/6cbdcf9142d00fe82836fbb51e503e58088575cf7a0fe1dbff6695bf0840/cryptography-50.0.0.tar.gz" | ||
| sha256 "eeac2acb5a20ed25e0ad6d1df9891a520b78b404266b6d11778f25d5d691a6c9" | ||
| end |
There was a problem hiding this comment.
Because virtualenv_install_with_resources builds this newly added sdist from source, a clean Homebrew builder must compile cryptography's Rust extension, but the formula declares no Rust build dependency. Replace this resource and its cffi/pycparser helpers with depends_on "cryptography" => :no_linkage and add cryptography to pypi_packages exclude_packages; otherwise source installation can fail before tests run.
AGENTS.md reference: AGENTS.md:L162-L162
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Updates the strimzi-kafka-cli Homebrew formula to the 1.0.0b3 PyPI release and refreshes the vendored Python dependency resources accordingly.
Changes:
- Bump
strimzi-kafka-clisource tarball from0.1.0a79to1.0.0b3(URL + SHA256). - Update/replace multiple Python resources (e.g.,
google-auth,requests,pyasn1, etc.). - Introduce new vendored resources (
cryptography,cffi,pycparser) as part of the dependency refresh.
Suppressed comments (1)
Formula/s/strimzi-kafka-cli.rb:109
google-authis vendored but thersaresource was removed.google-authdepends onrsa, so leaving this out will cause runtime failures whengoogle.authis imported/used.
Please restore the resource "rsa" block before installing six (as done in other formulae that vendor google-auth).
resource "six" do
url "https://files.pythonhosted.org/packages/94/e7/b2c673351809dca68a0e064b6af791aa332cf192da575fd474ed7d6f16a2/six-1.17.0.tar.gz"
sha256 "ff70335d468e7eb6ec65b95b99d3a2836546063f63acc5171de367e834932a81"
end
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| resource "cffi" do | ||
| url "https://files.pythonhosted.org/packages/9e/ef/008a1939e372c06329a3fce4279c02f328488f3526744906eeec3da7ad5f/cffi-2.1.1.tar.gz" | ||
| sha256 "dd31f52ea1086513bb9df30f8fcee9b8918323ae067a3d5b78bc826a000712be" | ||
| end |
| resource "cryptography" do | ||
| url "https://files.pythonhosted.org/packages/de/41/6cbdcf9142d00fe82836fbb51e503e58088575cf7a0fe1dbff6695bf0840/cryptography-50.0.0.tar.gz" | ||
| sha256 "eeac2acb5a20ed25e0ad6d1df9891a520b78b404266b6d11778f25d5d691a6c9" | ||
| end |
Created by
brew bumpCreated with
brew bump-formula-pr.