Add readable error for hwid - #38
Closed
drode1 wants to merge 1 commit into
Closed
Conversation
HWID is not supported by the client, so show readable error for it Signed-off-by: Egor Remezov <mr.drodel@gmail.com>
Closed
Owner
|
Honestly, I don't like this practice. The subscription server should take the responsibility to produce a human-readable error response, instead of reading a header and translated by the client. So I'll close this pr. |
Contributor
Author
|
It response in format of servers list, but app current show it till u open dashboard, neither show it on downloading sub |
Owner
|
That’s your subscription provider’s fault. Our client shouldn’t be held responsible for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HWID is not supported by the client, so show readable error for it