feat: WIP - upgrade resource and did modules to v0.50.x

.github/workflows/lint.yml

@@ -47,7 +47,7 @@ jobs:
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.56.2
+          version: v1.60.3
           args: --config .github/linters/.golangci.yaml
 
   proto-lint:

ante/expected_keepers.go

@@ -12,11 +12,11 @@ import (
 )
 
 type DidKeeper interface {
-	GetParams(ctx sdk.Context) (params didtypes.FeeParams)
+	GetParams(ctx context.Context) (didtypes.FeeParams, error)
 }
 
 type ResourceKeeper interface {
-	GetParams(ctx sdk.Context) (params resourcetypes.FeeParams)
+	GetParams(ctx context.Context) (params resourcetypes.FeeParams, err error)
 }
 type AccountKeeper interface {
 	GetParams(ctx context.Context) (params authtypes.Params)

ante/fee_test.go

@@ -313,7 +313,8 @@ var _ = Describe("Fee tests on DeliverTx", func() {
 		Expect(err).To(BeNil(), "Tx errored when fee payer had sufficient funds and provided sufficient fee while subtracting tax on deliverTx")
 
 		// get fee params
-		feeParams := s.app.DidKeeper.GetParams(s.ctx)
+		feeParams, err := s.app.DidKeeper.GetParams(s.ctx)
+		Expect(err).To(BeNil())
 
 		// check balance of fee payer
 		balance := s.app.BankKeeper.GetBalance(s.ctx, addr1, didtypes.BaseMinimalDenom)
@@ -378,7 +379,8 @@ var _ = Describe("Fee tests on DeliverTx", func() {
 		Expect(err).To(BeNil(), "Tx errored when fee payer had sufficient funds and provided sufficient fee while subtracting tax on deliverTx")
 
 		// get fee params
-		feeParams := s.app.ResourceKeeper.GetParams(s.ctx)
+		feeParams, err := s.app.ResourceKeeper.GetParams(s.ctx)
+		Expect(err).To(BeNil())
 
 		// check balance of fee payer
 		balance := s.app.BankKeeper.GetBalance(s.ctx, addr1, didtypes.BaseMinimalDenom)
@@ -1311,7 +1313,7 @@ var _ = Describe("Fee abstraction along with fee market", func() {
 		Status:                  types.HostChainFeeAbsStatus_UPDATED,
 	}
 
-	var feeabsModAcc authtypes.ModuleAccountI
+	var feeabsModAcc sdk.ModuleAccountI
 
 	var decorators []sdk.AnteDecorator
 	BeforeEach(func() {
@@ -1456,7 +1458,8 @@ var _ = Describe("Fee abstraction along with fee market", func() {
 		Expect(err).To(BeNil(), "Tx errored when fee payer had sufficient funds and provided sufficient fee while subtracting tax on deliverTx")
 
 		// get fee params
-		feeParams := s.app.DidKeeper.GetParams(s.ctx)
+		feeParams, err := s.app.DidKeeper.GetParams(s.ctx)
+		Expect(err).To(BeNil())
 
 		// check balance of fee payer
 		balance := s.app.BankKeeper.GetBalance(s.ctx, addr1, didtypes.BaseMinimalDenom)
@@ -1588,7 +1591,8 @@ var _ = Describe("Fee abstraction along with fee market", func() {
 		Expect(err).To(BeNil(), "Tx errored when fee payer had sufficient funds and provided sufficient fee while subtracting tax on deliverTx")
 
 		// get fee params
-		feeParams := s.app.DidKeeper.GetParams(s.ctx)
+		feeParams, err := s.app.DidKeeper.GetParams(s.ctx)
+		Expect(err).To(BeNil())
 
 		// check balance of fee payer
 		balance := s.app.BankKeeper.GetBalance(s.ctx, addr1, didtypes.BaseMinimalDenom)

ante/testutil_test.go

@@ -61,7 +61,7 @@ var (
 
 // TestAccount represents an account used in the tests in x/auth/ante.
 type TestAccount struct {
-	acc  authtypes.AccountI
+	acc  sdk.AccountI
 	priv cryptotypes.PrivKey
 }
 
@@ -90,9 +90,12 @@ func createTestApp(isCheckTx bool) (*cheqdapp.TestApp, sdk.Context, error) {
 
 	// cheqd specific params
 	didFeeParams := didtypes.DefaultGenesis().FeeParams
-	app.DidKeeper.SetParams(ctx, *didFeeParams)
+	err = app.DidKeeper.SetParams(ctx, *didFeeParams)
+	if err != nil {
+		return nil, sdk.Context{}, err
+	}
 	resourceFeeParams := resourcetypes.DefaultGenesis().FeeParams
-	app.ResourceKeeper.SetParams(ctx, *resourceFeeParams)
+	_ = app.ResourceKeeper.SetParams(ctx, *resourceFeeParams)
 	err = app.FeeMarketKeeper.SetParams(ctx, types.NewParams(DefaultWindow, DefaultAlpha, DefaultBeta, DefaultGamma, DefaultDelta,
 		DefaultMaxBlockUtilization, DefaultMinBaseGasPrice, DefaultMinLearningRate, DefaultMaxLearningRate, DefaultFeeDenom, true,
 	))
@@ -217,13 +220,13 @@ func (s *AnteTestSuite) CreateTestTx(privs []cryptotypes.PrivKey, accNums []uint
 }
 
 // SetDidFeeParams is a helper function to set did fee params.
-func (s *AnteTestSuite) SetDidFeeParams(feeParams didtypes.FeeParams) {
-	s.app.DidKeeper.SetParams(s.ctx, feeParams)
+func (s *AnteTestSuite) SetDidFeeParams(feeParams didtypes.FeeParams) error {
+	return s.app.DidKeeper.SetParams(s.ctx, feeParams)
 }
 
 // SetResourceFeeParams is a helper function to set resource fee params.
-func (s *AnteTestSuite) SetResourceFeeParams(feeParams resourcetypes.FeeParams) {
-	s.app.ResourceKeeper.SetParams(s.ctx, feeParams)
+func (s *AnteTestSuite) SetResourceFeeParams(feeParams resourcetypes.FeeParams) error {
+	return s.app.ResourceKeeper.SetParams(s.ctx, feeParams)
 }
 
 func (s *AnteTestSuite) SetFeeMarketFeeDenom() error {

ante/tx_msg_filters.go

@@ -108,12 +108,18 @@ func GetResourceTaxableMsgFee(ctx sdk.Context, msg *resourcetypes.MsgCreateResou
 }
 
 func checkFeeParamsFromSubspace(ctx sdk.Context, didKeeper DidKeeper, resourceKeeper ResourceKeeper) bool {
-	didParams := didKeeper.GetParams(ctx)
+	didParams, err := didKeeper.GetParams(ctx)
+	if err != nil {
+		return false
+	}
 	TaxableMsgFees[MsgCreateDidDoc] = sdk.NewCoins(didParams.CreateDid)
 	TaxableMsgFees[MsgUpdateDidDoc] = sdk.NewCoins(didParams.UpdateDid)
 	TaxableMsgFees[MsgDeactivateDidDoc] = sdk.NewCoins(didParams.DeactivateDid)
 
-	resourceParams := resourceKeeper.GetParams(ctx)
+	resourceParams, err := resourceKeeper.GetParams(ctx)
+	if err != nil {
+		return false
+	}
 	TaxableMsgFees[MsgCreateResourceImage] = sdk.NewCoins(resourceParams.Image)
 	TaxableMsgFees[MsgCreateResourceJSON] = sdk.NewCoins(resourceParams.Json)
 	TaxableMsgFees[MsgCreateResourceDefault] = sdk.NewCoins(resourceParams.Default)

ante/tx_msg_filters_test.go

@@ -14,7 +14,7 @@ import (
 )
 
 var _ = Describe("TxMsgFilters", func() {
-	var rounds int = 1_000_000
+	rounds := 1_000_000
 
 	BeforeEach(func() {
 		ante.TaxableMsgFees = ante.TaxableMsgFee{