Skip to content

docs(requestcontrol): correct FlowControlAdmissionController.Admit docstring #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chethanuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(requestcontrol): correct FlowControlAdmissionController.Admit docstring #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/epp/requestcontrol/admission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ func NewFlowControlAdmissionController(fc flowController, poolName string) *Flow
}
}

// Admit implements the AdmissionController interface by checking for saturation on sheddable requests first, then
// deferring to the Flow Control system.
// Admit defers the admission decision to the Flow Control system via EnqueueAndWait; saturation-based shedding
// of sheddable requests is handled downstream by the dispatch cycle, not at admission.
func (fcac *FlowControlAdmissionController) Admit(
ctx context.Context,
reqCtx *handlers.RequestContext,
Expand Down
Loading