test: extract EPP envtest harness into test/framework/epp/harness#36
test: extract EPP envtest harness into test/framework/epp/harness#36chethanuk wants to merge 1 commit into
Conversation
The harness is the only remaining piece of shared EPP integration setup that lives under test/integration; moving it lets suites outside that directory drive an envtest-backed EPP without duplicating the bootstrap. The harness needs envtest and is exercised by test-integration-hermetic, so it is excluded from the framework unit-coverage component to avoid reporting 0% for code that is in fact covered. Part of llm-d#1188 Signed-off-by: ChethanUK <chethanuk@outlook.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the test framework by moving the test harness and associated metrics/data structures (such as PodState, P, and metric helper functions) from the epp package into a dedicated harness package (test/framework/epp/harness). The Makefile is updated to exclude this harness from unit test coverage calculations, and all integration tests are updated to import and use the new eppharness package. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
What type of PR is this?
/kind cleanup
/kind test
What this PR does / why we need it:
Last of eight in the llm-d#1188 split. It follows the harness API PR, which did the
semantic work so this one reads as a move.
The harness goes from
test/integration/epptotest/framework/epp/harness.common_tests.gocannot keep its pod and metric helpers, becauseWithPodsandWaitForReadyPodsMetricuse every one of them.It gets its own package at the bottom of the tree: it imports
cmd/epp/runnerand sothe whole server, so only
test/integration/eppand future e2e suites import it, nevera test under
pkg/, which would risk a cycle back into the runner's dependencies.One thing is not the move: the Makefile drops the harness from
framework_TEST_PACKAGES, sincemake test-unit-frameworkstarts no API server andwould report zero coverage for code the hermetic suite exercises.
Test plan:
go buildandgo vet ./test/...clean at this commitmake test-integration-hermeticpasses, 68 tests, no failures, so the embedresolves at the new path
go test ./test/framework/...passes with the harness out of the setWhich issue(s) this PR fixes:
Part of llm-d#1188
Release note (write
NONEif no user-facing change):