Skip to content

Allow to pass multiple lists of column coordinates #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markojaadam wants to merge 2 commits into from
Closed

Allow to pass multiple lists of column coordinates #406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79dde0e
Allow to pass multiple list of column coordinates
markojaadam Jun 6, 2025
6b5c12a
Lint fix
markojaadam Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions tabula/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class TabulaOption:
stream: bool = False
password: Optional[str] = None
silent: Optional[bool] = None
columns: Optional[Sequence[float]] = None
columns: Optional[Union[Sequence[float], Sequence[Sequence[float]]]] = None
Copy link
Owner

@chezou chezou Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I didn't know multiple areas can be passed.

https://github.com/tabulapdf/tabula-java/blob/2cdf3b4fd3f7e921dca8cc6814cdd9316be40f0f/src/test/java/technology/tabula/TestCommandLineApp.java#L158-L160

relative_columns: bool = False
format: Optional[str] = None
batch: Optional[str] = None
Expand Down Expand Up @@ -236,11 +236,22 @@ def build_option_list(self) -> List[str]:
__options += ["--outfile", self.output_path]

if self.columns:
if list(self.columns) != sorted(self.columns):
raise ValueError("columns option should be sorted")
if isinstance(self.columns, (list, tuple)):
if any(type(e) in [list, tuple] for e in self.columns):
for e in self.columns:
if list(e) != sorted(e):
raise ValueError(
"columns option should be sorted for each column"
)

__columns = _format_with_relative(e, self.relative_columns)
__options += ["--columns", __columns]
else:
if list(self.columns) != sorted(self.columns):
raise ValueError("columns option should be sorted")

__columns = _format_with_relative(self.columns, self.relative_columns)
__options += ["--columns", __columns]
__columns = _format_with_relative(self.columns, self.relative_columns)
__options += ["--columns", __columns]

if self.password:
__options += ["--password", self.password]
Expand Down
Loading