fix: address review feedback on PR #259 — Stripe PaymentIntent + CI security fixes - #1
Open
laurentketterle-hub wants to merge 8 commits into
Conversation
- Webhook handler with Stripe-Signature verification - Payment intent event mapping (succeeded/failed/refunded) - MRG credit minting + ledger proof on settlement - Store persistence for Stripe payments
…te loop + fix snapshot serialization
…atus mapping - parseStripeSignatureHeader: valid, multi-sig, missing/invalid ts/sig - verifyStripeWebhookSignature: correct/wrong sig, dev skip, prod require - stripeWebhookPaymentFromEvent: succeeded/failed/refunded/unsupported edge cases: missing ID, wrong status, non-USD, zero amount, fallback - Integration: missing header 401, bad sig 401, full settlement flow - Deduplication: replay same event returns duplicate=true - Failed/refunded webhooks update project PaymentStatus
- TestStripeWebhook_DedupPersistenceAcrossReload: end-to-end test proving dedup map survives save → close → reopen (JSON state persistence) - TestRecordStripeSettlement_EmptyEventID - TestRecordStripeSettlement_EmptyPaymentIntentID - TestRecordStripeSettlement_UnknownStatus - TestRecordStripeSettlement_FailedDedup - TestRecordStripeSettlement_RefundedDedup All existing tests continue to pass.
…fund events with idempotent reversal, timestamp recency, atomic persistence
…t high severity (nanoid, postcss)
Author
|
✅ This PR is ready to merge — CI is green, no changes requested. Please review and merge. On-chain settlement ready. /claim 0x954dB727f224dAabe4F87E799843C2bB62dfd26C |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chfr19820610-cell Changes requested addressed:
CI is clean. Ready for re-review and merge.