Fix write example for recordingYear where wrong parameter is used in ID3FrameWithIntegerContent - #115
Merged
Merged
Conversation
…r is used, but the method only accepts value.
chicio
approved these changes
Jan 17, 2026
chicio
left a comment
Owner
There was a problem hiding this comment.
Hi @Anrufliste , thank you so much for the contribution 🙏
Yes, you're right. The documentation for the recording year frame is wrong as you mentioned in #116.
Merging now. I will add you to the contributors.
Please star this repository to support my work 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ID3FrameWithIntegerContent has wrong parameter name, from context year is used, but the method only accepts value.
Description
In the example the parameter year is replaced by value. I assume year was wrongly taken because of ID3Tag context, but the helper method does know that context and is used in general for.
Motivation and Context
It helps to keep the documentation correct and if some one just copy and pastes the example code is will compile.
How Has This Been Tested?
It's just a fix for the documentation and I used the code within a project. That's how I found that mismatch.
Types of changes
Checklist: