Skip to content

Conversation

@andersmmg
Copy link

@andersmmg andersmmg commented Jan 4, 2026

Fixes #201

@wlsnmrk
Copy link
Contributor

wlsnmrk commented Jan 4, 2026

Thanks, this looks great! Would you be willing to add a test (in GodotEnv.Tests) to verify that the subdirectory creation works as expected?

@andersmmg
Copy link
Author

I'll look into that, good point!

@andersmmg
Copy link
Author

I updated the tests and they all pass, lmk if any changes are needed

Copy link
Member

@jolexxa jolexxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

I'm always a little scared to merge anything that touches addon resolution, but I suspect this will not break the existing addon dependency system, especially if you have tested locally and confirmed that it will re-install an addon in a subdirectory on top of itself by clearing it out and re-copying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom target directories

3 participants