Fix list_topics crash on Telethon 1.42#91
Open
embogomolov wants to merge 1 commit intochigwell:mainfrom
Open
Conversation
Telethon 1.42 does not generate a wrapper for the channels.getForumTopics TL method, causing list_topics to fail with AttributeError. Add a manual TLRequest implementation (GetForumTopicsRequest) that serializes the request according to the TL schema: channels.getForumTopics#de560d1 Replace the broken functions.channels.GetForumTopicsRequest call in list_topics with the new manual implementation.
Author
|
Anyone? |
Owner
|
Hey @embogomolov, thank you for the contribution! Could I please ask you to fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
Telethon 1.42 doesn't generate a Python wrapper for the
channels.getForumTopicsTL method. Callingfunctions.channels.GetForumTopicsRequest(...)inlist_topicsthrows anAttributeErrorbecause the class simply doesn't exist in this version.The fix
Hand-wrote the TL request class (
GetForumTopicsRequest) following the schema:It extends
TLRequest, handles binary serialization manually viastruct.pack, and supports the optionalq(search query) flag. Replaces the missing auto-generated class in thelist_topicscall.How to test
list_topicswith its IDsearch_queryparameter