bids2table 2.0#48
Merged
Merged
Conversation
- BIDS schema loaded from `bidschematools` following previous impl (thx @nx10). - Add Arrow schema construction - Otherwise, trying to make much simpler. No dataclass complexity.
New indexing uses just `Path` operations and string processing. Generates arrow tables directly with no other dependencies. ~400 LOC. Supports indexing cloud-hosted datasets via `cloudpathlib`. Thanks to @nx10 for these suggestions.
- Don't raise error, just warn and return empty table if a dataset is empty. - Add package-level exports.
TODO: test
Accepting unexpanded glob patterns in CLI is useful for cloud sources. May as well accept a list of them. Few other misc cleanup (simplify log messages, progress bar).
- Format large file counts in human readable units. - Change verbosity order: progress bar -> warnings. - Filter repeated logging messages. - Initialize logger state in each process when using `ProcessPoolExecutor`.
A dynamically defined global enum for the column names is a bit awkward and not that useful. The column names are not available statically in the editor for example. Remove and replace with a `get_column_names` function which dynamically defines the column name enum.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 93.18% 94.61% +1.42%
==========================================
Files 10 6 -4
Lines 558 427 -131
==========================================
- Hits 520 404 -116
+ Misses 38 23 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Make informational, don't fail CI jobs
Disable progress bar by default in python index functions. Enable progress bar by default in CLI. Add a `--no-progress` flag.
This was referenced May 6, 2025
This was referenced May 6, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a full rewrite of bids2table aiming to make the project much simpler while also adding a few useful new features. The major changes are:
Credit to @nx10 for suggesting these directions and providing useful feedback.
cc: @effigies, @adelavega