97 task write trails velocity feature functions detect hesitations correct#117
Merged
cgmaiorano merged 27 commits intoFeb 16, 2026
Conversation
…ons-calculate_segment_velocity_metrics
… class but will be calculated outside for sake of simplicity
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 98.59% 98.61% +0.01%
==========================================
Files 19 19
Lines 1067 1080 +13
==========================================
+ Hits 1052 1065 +13
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ons-detect_hesitations_correct
Asanto32
reviewed
Feb 13, 2026
Collaborator
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Looks good, just some documentation fixes, and resolving issues in models and test that came from the merge (old version)
| hesitations = self.velocities < threshold | ||
|
|
||
| hesitation_changes = np.diff(hesitations.astype(int)) | ||
| hesitation_starts = np.where(hesitation_changes == 1)[0] + 1 |
Collaborator
There was a problem hiding this comment.
What's the +1 for? I would assume the +1 for the start is covered by the if statement below?
Collaborator
Author
There was a problem hiding this comment.
+1 handles when the linesegment starts with a hesitation
Asanto32
approved these changes
Feb 16, 2026
Collaborator
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
lgtm, just see the change to hesitation_count computation I suggested
Co-authored-by: Adam Santorelli <148909356+Asanto32@users.noreply.github.com>
cgmaiorano
deleted the
97-task-write-trails-velocity-feature-functions-detect_hesitations_correct
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr completes #97 and #98
detect_hesitations is a classmethod that defines a hesitation as any period where the velocity falls below a certain threshold, which is determined by the specified percentile of the velocity distribution. It counts the number of distinct hesitation periods and adds 1 if the line starts with a hesitation. It also calculates the total duration of hesitations based on the number of points that fall below the threshold and the time interval between points.