chore/issue1/update-metadata#30
Conversation
…d description and examples, refine SECURITY.md reporting instructions, and modify pyproject.toml for additional authors and description clarity.
…E.md with style guide references and improved descriptions.
alperkent
added
documentation
alperkent
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 296 296
=========================================
Hits 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@Asanto32 made all the fixes you suggested and added the pypi workflow as well. Once we merge it should automatically publish! 🤞 |
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Small question about the pypi CI but otherwise lgtm
| ls -la dist/ | ||
| python -c "import tarfile; tarfile.open('dist/*.tar.gz').getnames()" || true | ||
|
|
||
| - name: Publish to PyPI |
There was a problem hiding this comment.
will this job work without the PYPI token?
There was a problem hiding this comment.
apparently it is more secure without the tokens using this OpenID Connect method. we'll see if it works lol
| if: steps.version-check.outputs.version_changed == 'true' | ||
| run: uv build | ||
|
|
||
| - name: Verify build artifacts |
There was a problem hiding this comment.
what's this job needed for?
There was a problem hiding this comment.
it's basically a sanity check that makes sure that the distribution artifacts exist and can be opened before attempting to upload them to PyPI. i wanted to try and see, if it adds too much overhead i'll remove it.
4 participants
Resolves #1.