feature/issue-29/implement-caching#31
Merged
Merged
Conversation
alperkent
added
enhancement
alperkent
commented
Jul 7, 2025
Asanto32
reviewed
Jul 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 296 305 +9
=========================================
+ Hits 296 305 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ancy and change cache directory path from "data" to "cache"
… spiral generation to improve performance, convert SpiralConfig to frozen dataclass for immutability necessary for caching, and fix center_spiral to modify a copied SpiralConfig instead of the original
Collaborator
Author
|
@Asanto32 refactored the reference spiral generation to do incremental arc length calculation instead, which improves the performance as @reindervdw-cmi suggested. |
…generate_reference_spiral.py
Asanto32
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #29 with an additional small fix to test workflow.