-
Notifications
You must be signed in to change notification settings - Fork 4
Enable remote data downloading #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaitj
wants to merge
8
commits into
main
Choose a base branch
from
enh/remote-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3f675ef
Add dependencies necesary to download remote
kaitj 6b2ca6e
Add osf fetcher, update codebase + tests
kaitj 8ded565
Add tests for remote fetcher
kaitj e65feee
Revert uri in graph to local storage
kaitj c0132af
Allow local path = uri; update volume building
kaitj 305e05b
Fix deptry errors
kaitj 8172137
More robust storage host check
kaitj e3d05a5
Add additional human + chimp nodes and edges (#150)
kaitj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| """Helpers for grabbing from remote repositories.""" | ||
|
|
||
| from pathlib import Path | ||
| from typing import Literal | ||
|
|
||
| from neuromaps_prime.remote import OSFStorage | ||
|
|
||
|
|
||
| def id_storage(uri: str) -> Literal["osf"] | None: | ||
| """Identify the storage type. | ||
|
|
||
| Args: | ||
| uri: Remote URI to fetch data from | ||
|
|
||
| Returns: | ||
| String indicating type of storage (one of 'osf') | ||
| """ | ||
| if "osf.io" in uri: | ||
Check failureCode scanning / CodeQL Incomplete URL substring sanitization High
The string
osf.io Error loading related location Loading |
||
| return "osf" | ||
| return None | ||
|
|
||
|
|
||
| def download_and_validate(uri: str, dest: str | Path) -> None: | ||
| """Download and validate the file. | ||
|
|
||
| Args: | ||
| uri: Remote URI to fetch data from | ||
| dest: Output file path name | ||
| token: Optional token to use for remote storage | ||
|
|
||
| Raises: | ||
| ValueError: if storage cannot be identified from provided URI | ||
| """ | ||
| match id_storage(uri): | ||
| case "osf": | ||
| OSFStorage().download(uri, Path(dest)) | ||
| case _: | ||
| raise ValueError(f"Could not identify storage from uri: {uri}") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| """Module associated with remote storages.""" | ||
|
|
||
| from .osf import OSFStorage | ||
|
|
||
| __all__ = ["OSFStorage"] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.