Skip to content

Docs: resource GH templates Fix #102#152

Open
jpillai00 wants to merge 5 commits into
mainfrom
templates/contribute-resources
Open

Docs: resource GH templates Fix #102#152
jpillai00 wants to merge 5 commits into
mainfrom
templates/contribute-resources

Conversation

@jpillai00
Copy link
Copy Markdown
Contributor

@jpillai00 jpillai00 commented May 27, 2026

  • Added resource request issue template at .github/ISSUE_TEMPLATE/resource_request.yaml
  • Added general PR template at .github/pull_request_template.md

Closes #102

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
neuromaps_prime
   __init__.py00100% 
   niwrap.py560100% 
neuromaps_prime/graph
   __init__.py80100% 
   builder.py110298%329, 397
   cache.py1130100% 
   core.py890100% 
   models.py760100% 
   utils.py530100% 
neuromaps_prime/graph/transforms
   __init__.py00100% 
   surface.py970100% 
   volume.py400100% 
neuromaps_prime/resources
   __init__.py120100% 
neuromaps_prime/transforms
   __init__.py00100% 
   surface.py350100% 
   utils.py290100% 
   volume.py190100% 
TOTAL737299% 

Tests Skipped Failures Errors Time
222 2 💤 0 ❌ 0 🔥 13.109s ⏱️

@jpillai00 jpillai00 linked an issue May 27, 2026 that may be closed by this pull request
2 tasks
@jpillai00 jpillai00 marked this pull request as ready for review May 27, 2026 23:48
@jpillai00 jpillai00 requested review from kaitj and tamsinrogers May 27, 2026 23:48
Copy link
Copy Markdown
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a great start, really just a minor change I would make.

Comment on lines +11 to +19
## Resource Contribution (if applicable)
**Resource Type:** (Annotation / Atlas / Transform / Other)

**Resource URI:**

**References:**

**YAML Changes:**
<!-- Which YAML file(s) were updated and under which resource category? -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need these details to be included in the PR - these would show up in the PR diff anyways. This should definitely be checked by the review though.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be a little too specific on the details. This to me seems like it would be good if we expect a single issuer per resource, but if someone wants to contribute an entire dataset that seems like it would be a lot of issues. I would probably generalize this more instead of singular dropdowns (maybe checkboxes). I guess I am primarily thinking of resource-type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Add GH template(s) for adding resource

2 participants