Skip to content

Tf cycle#198

Draft
tfunck wants to merge 2 commits into
mainfrom
tf-cycle
Draft

Tf cycle#198
tfunck wants to merge 2 commits into
mainfrom
tf-cycle

Conversation

@tfunck

@tfunck tfunck commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

PR Overview

This branch adds end-to-end cycle regression testing on the real Neuromaps graph to validate transform roundtrip quality across multi-hop paths.

#What’s included

  1. New real-graph cycle regression tests
  • Enumerate return paths from origin spaces
  • Run hop-by-hop surface roundtrips
  • Score path quality (Pearson r, max absolute difference)
    2 . Artifact generation for debugging
  • Per-run output folders with random suffixes
  • CSV/TXT summaries and per-path transform manifests
  • Surface plots and optional wb_command logs
    3 Robust execution across real data variability
  • Runs both left and right hemispheres
  • Falls back for area surfaces in order:
    ** midthickness
    ** pial
    ** white
  • Skips unusable paths/resources with clear warnings instead of hard-failing whole runs
    Container-safe output handling
  1. Adds an additional dependency, matplotlib_surface_plotting, for visual QC artifacts.

tfunck added 2 commits July 16, 2026 22:20
…dtrip transformation of a metric from and back to a given space
…nodes in the graph, 2) test both left and right hemisphere, 3) try pial then white surface, if midsurface is missing for some reason
@tfunck
tfunck requested a review from kaitj July 17, 2026 03:00

@kaitj kaitj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks like a great starting point for us to make the tests more robust. I think there are a lot of things we can move to be test fixtures that can be re-used across the different testing modes (unit, regression, etc.). We'll put together a plan to tackle this "testing" milestone!

There are some ruff CI complaints, but not too worried about those as we can tackle those as part of making the tests more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants