Conversation
…dtrip transformation of a metric from and back to a given space
…nodes in the graph, 2) test both left and right hemisphere, 3) try pial then white surface, if midsurface is missing for some reason
kaitj
reviewed
Jul 20, 2026
Contributor
There was a problem hiding this comment.
🚀 Looks like a great starting point for us to make the tests more robust. I think there are a lot of things we can move to be test fixtures that can be re-used across the different testing modes (unit, regression, etc.). We'll put together a plan to tackle this "testing" milestone!
There are some ruff CI complaints, but not too worried about those as we can tackle those as part of making the tests more robust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
This branch adds end-to-end cycle regression testing on the real Neuromaps graph to validate transform roundtrip quality across multi-hop paths.
#What’s included
2 . Artifact generation for debugging
3 Robust execution across real data variability
** midthickness
** pial
** white
Container-safe output handling