Stage 1: split longitudinal code into dedicated submodules#305
Merged
Conversation
Pure file-move refactor. No behavior change.
- workflows/{anatomical,functional}.py::longitudinal_process and
*LongOutputs move to workflows/longitudinal/{anatomical,functional}.py
- bids/longitudinal.py splits into bids/longitudinal/{anatomical,functional}.py
- orchestration/longitudinal.py splits into
orchestration/longitudinal/{__init__,anatomical,functional}.py
(run() stays in __init__; process_anat / process_func move out)
All callers updated atomically; no re-export shims. Test patch paths
updated to reference the new submodule locations.
Stage 1 of longitudinal refactor (tracker #301).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure file-move refactor. No behavior change, no public API change, no CLI surface change.
Changes
workflows/anatomical.py::longitudinal_process+AnatomicalLongOutputs→
workflows/longitudinal/anatomical.pyworkflows/functional.py::longitudinal_process+FunctionalLongOutputs→
workflows/longitudinal/functional.pybids/longitudinal.py→
bids/longitudinal/{__init__,anatomical,functional}.pyorchestration/longitudinal.py→
orchestration/longitudinal/{__init__,anatomical,functional}.py(
run()stays at package level;process_anat/process_funcmove to submodules)All callers updated atomically in this PR. No re-export shims. Test patch paths in
tests/unit/orchestration/test_longitudinal.pyupdated to reference the new submodule locations.Tracker
Part of #301 — Stage 1.
Test plan
uv run ruff check src/ tests/— cleanuv run mypy src/ tests/— cleanuv run pytest -m unit— 732 passed, 1 skippeduv run pytest -m "integration and not slow" --runner docker— 0 tests collected (all integration tests in the repo are currently markedslow; vacuously passes)