Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates RBC’s tabular derivatives to use Parquet instead of TSV and renames the correlation-matrix output to a more general “connectome”, aligning file naming/suffixes and updating tests accordingly.
Changes:
- Switched QC and timeseries/connectome outputs from TSV to Parquet (
write_csv→write_parquet,.tsv→.parquet). - Renamed “correlations/correlation_matrix” outputs to “connectome” across workflows and BIDS exports.
- Updated unit/integration tests to read Parquet and reflect the new output naming (and intended timeseries orientation change).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/orchestration/test_qc.py | Updates mocked QC output filename to .parquet. |
| tests/unit/core/test_timeseries.py | Updates round-trip tests to read Parquet and expect connectome output. |
| tests/unit/core/qc/test_xcp.py | Updates QC writer tests to validate Parquet column names/values. |
| tests/unit/bids/test_exports.py | Updates expected exported metric/QC filenames and extensions to Parquet and connectome naming. |
| tests/integration/test_all.py | Updates integration glob patterns to expect Parquet timeseries/connectome/QC outputs. |
| tests/integration/functional/qc/test_xcp.py | Updates integration QC test to write/read Parquet. |
| src/rbc/workflows/qc.py | Writes QC metrics to .parquet in the QC workflow. |
| src/rbc/workflows/metrics.py | Renames metrics output field from correlation_matrix to connectome. |
| src/rbc/core/qc/xcp.py | Writes QC metrics as a Parquet file via Polars. |
| src/rbc/core/metrics/timeseries.py | Writes timeseries + connectome to Parquet and renames output path for connectome. |
| src/rbc/bids/qc.py | Exports QC derivative with .parquet extension. |
| src/rbc/bids/metrics.py | Exports timeseries/connectome derivatives as Parquet and updates suffix to connectome. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #247 and #91
TSV -> Parquet
pl.write_csvtopl.write_parquetextension=".parquet"Note: only timeseries and connectome outputs are switched to Parquet, the XCP quality file stays as a tsv
correlations -> connectome
Updated tests & verified values are identical to TSV outputs by comparing previous/new outputs for a test sub/ses
Note on orientation
Timeseries output preserves the original (ROIs × timepoints) orientation from the TSV, with timepoint indices as columns. The connectome now has ROI labels as named columns. Values are identical to previous outputs.