add DVFinal CPAC bug to divergences notes#329
Merged
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
Adds a new documented divergence between C-PAC and RBC related to DVARS (“DVFinal”) QC metrics, clarifying that C-PAC appears to compute meanDVFinal / motionDVCorrFinal from the same pre-regression BOLD input as DVInit, while RBC computes DVFinal from post-regression (cleaned) BOLD.
Changes:
- Documented a new divergence:
DVFinalmetrics in C-PAC QC output matchDVInit(pre-regression), based on source inspection and empirical checks across datasets. - Added a brief contrast note describing RBC’s intended/correct
DVFinalcomputation source.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds finding that CPAC computes
meanDVFinalandmotionDVCorrFinalfrom pre-regression BOLD (instead of post-regression BOLD), confirmed empirically across HBN, PNC, and NKI datasets during benchmarking.e.g.
meanDVInitandmeanDVFinalvalues are exactly the same for CPAC