Move and restructure CPAC comparison notes#341
Merged
Conversation
|
gkiar
approved these changes
May 21, 2026
kaitj
approved these changes
May 21, 2026
kaitj
reviewed
May 21, 2026
|
|
||
| --- | ||
|
|
||
| ### 6. Motion correction runs twice (pre-STC for regressors, post-STC for spatial application) |
Contributor
There was a problem hiding this comment.
Suggested change
| ### 6. Motion correction runs twice (pre-STC for regressors, post-STC for spatial application) | |
| ### 4. Motion correction runs twice (pre-STC for regressors, post-STC for spatial application) |
Contributor
|
Content wise looks good, numbering of the headers is throwing me off a little based on where they are, but otherwise lgtm. |
Contributor
Author
|
Yes did not want to change the numbering from before because I referred to them by their number in many notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
tests/data/cpac_rbc_divergences.mdtodocs/cpac_comparison.md(it's reference material, not a test fixture, and the old name was a bit jargony for someone scanningdocs/for the first time).While there, split the findings into two sections:
#4TR/bandpass,#5DVFinal = DVInit) - unambiguous numerical or spec-vs-implementation errors.#1N4 discarded,#2despike in template,#3ALFF as std, plus a new#6on CPAC's duplicate motion correction) - differences from RBC's approach that may reflect intentional design choices in CPAC.Also folded the old "Two parallel motion correction paths" note into the new
#6divergence so the RBC-vs-CPAC contrast is explicit.