Skip to content

Setup testing#37

Merged
kaitj merged 9 commits into
mainfrom
enh/testing
Feb 3, 2026
Merged

Setup testing#37
kaitj merged 9 commits into
mainfrom
enh/testing

Conversation

@kaitj
Copy link
Copy Markdown
Contributor

@kaitj kaitj commented Feb 2, 2026

  • Adds testing tiers (nothing implemented here yet)
  • Updated actions workflow triggering slow + e2e (separate flag) tests manually
  • Added fixture markers and initial fixtures
  • Added initial testing README (partially generated to provide context)

I think some of these things may change as we actually start to write tests but this sets up an initial structure.

Closes #13

@kaitj kaitj requested a review from nx10 February 2, 2026 21:09
@kaitj kaitj self-assigned this Feb 2, 2026
Comment thread tests/README.md
## Coverage Requirements

- **Overall:** >85%
- **Unit tests:** >90%
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this will be possible - maybe with the dry runner it will

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be, at least for unit testing...integration testing might take longer.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the 90% min

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall find out. Arbitrary numbers 🤷‍♂️

Comment thread tests/README.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep abridged version in README and move full guide to seperate markdown doc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or full guide as section in contributing md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, make each less relevant subsection a dropdown. Not the biggest fan of that, but 🤷. I'll take a look to see what I did for other repos - probably not a lot 😂

@nx10
Copy link
Copy Markdown
Contributor

nx10 commented Feb 2, 2026

Do we need to make sure test data is not included in wheels/built package or is tests/ excluded anyway

@kaitj
Copy link
Copy Markdown
Contributor Author

kaitj commented Feb 3, 2026

Do we need to make sure test data is not included in wheels/built package or is tests/ excluded anyway

It should be excluded in the build, but can double check.

EDIT: Only src is built with the way this repo is setup.

@kaitj kaitj requested a review from nx10 February 3, 2026 21:10
@kaitj
Copy link
Copy Markdown
Contributor Author

kaitj commented Feb 3, 2026

Shortened the test README - a lot of unnecessary fluff there.
This also adds an initial implementation for the testing across OS' though this is currently happening for all tests. Should we break down each tier of testing into its own job and then combine the coverage later on (or we can fix this later on too).

Copy link
Copy Markdown
Contributor

@nx10 nx10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kaitj kaitj merged commit 95999a8 into main Feb 3, 2026
1 of 6 checks passed
@kaitj kaitj deleted the enh/testing branch February 3, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set Up Test Data and Testing Infrastructure

2 participants