Skip to content

Bug fixes to anatomical workflow#40

Merged
kaitj merged 3 commits into
mainfrom
maint/anatomical
Feb 6, 2026
Merged

Bug fixes to anatomical workflow#40
kaitj merged 3 commits into
mainfrom
maint/anatomical

Conversation

@kaitj
Copy link
Copy Markdown
Contributor

@kaitj kaitj commented Feb 6, 2026

A couple of small bug fixes for the anatomical workflow (tested and confirmed working locally e2e).

  1. Updated fslmaths call - I think this changed in the most recent niwrap version
  2. Updated composite transform paths (was previously passing the object instead of the file path)

Tests coming in separate PR.

@kaitj kaitj requested a review from nx10 February 6, 2026 16:56
@kaitj kaitj self-assigned this Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 29.50%. Comparing base (56dfd40) to head (a0435ba).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rbc/core/anatomical/registration.py 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (29.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   29.50%   29.50%           
=======================================
  Files           7        7           
  Lines          61       61           
=======================================
  Hits           18       18           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@nx10 nx10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we should switch from simplenamespace to namedtuples or dataclasses in subsequent PRs. Dynamic class creation isn't needed here.

@kaitj
Copy link
Copy Markdown
Contributor Author

kaitj commented Feb 6, 2026

Yah, lets chat more about that offline.

I originally had it as a dataclass, but its really only used here to return paths in a single "object" once, wasn't sure it made sense and also the immutability of the namedtuples, but definitely open to it.

@kaitj kaitj merged commit 1590855 into main Feb 6, 2026
7 of 8 checks passed
@kaitj kaitj deleted the maint/anatomical branch February 6, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants