Skip to content

Add initial pipeline flow graphic draft#45

Merged
nx10 merged 5 commits into
mainfrom
pipeline-flow-figure
Feb 27, 2026
Merged

Add initial pipeline flow graphic draft#45
nx10 merged 5 commits into
mainfrom
pipeline-flow-figure

Conversation

@nx10
Copy link
Copy Markdown
Contributor

@nx10 nx10 commented Feb 6, 2026

No description provided.

@nx10 nx10 requested a review from kaitj February 6, 2026 20:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

The author of this PR, nx10, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

Copy link
Copy Markdown
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I don't know if things will end up changing or not. Is the goal just to be an overview with some documentation later on that describes everything?

Copy link
Copy Markdown
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do we want to include the reorientation step (this is common to both)
  • Anatomical
    • I would be a bit more specific about which MNI152 template if possible. I think it should be MNI152NLin6Asym, but might need to double check.
  • QC
    • I'm also not sure that the original workflow provided pass/fail or just the metrics (maybe XCP did)
  • The single-step resample, I would just say 2mm, maybe leave out MNI (this is a little confusing, or do you mean the template is resampled?)

@kaitj
Copy link
Copy Markdown
Contributor

kaitj commented Feb 9, 2026

Just me being picky now, but the ellipsis are outside / on the border of the box.

{3528CC34-24D2-4C1D-BBEF-C20362AD7D64}

@github-actions
Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/rbc
   __init__.py10100% 
src/rbc/cli
   __init__.py110%9
   anatomical.py110%3
   derivatives.py110%8
   functional.py110%10
   longitudinal.py110%9
   qc.py110%9
src/rbc/core
   __init__.py30100% 
   bids.py3620100% 
   common.py90100% 
   fileops.py27485%66–69
   nifti.py70100% 
   niwrap.py250100% 
src/rbc/core/anatomical
   __init__.py40100% 
   registration.py14471%45, 137, 152, 167
   segmentation.py15566%48, 74–75, 82, 93
src/rbc/core/functional
   __init__.py50100% 
   despiking.py50100% 
   initialization.py7185%61
   motion.py22577%79, 89, 91–92, 94
src/rbc/core/longitudinal
   __init__.py110%10
src/rbc/core/metrics
   __init__.py00100% 
   reho.py651183%180, 182–184, 186, 188–191, 193–194
src/rbc/core/qc
   __init__.py110%7
src/rbc/core/resources
   __init__.py150100% 
src/rbc/workflows
   __init__.py30100% 
   anatomical.py251732%46–50, 54–57, 60, 64, 67–70, 76, 83
   functional.py30300%7, 9–11, 13–16, 26, 48–53, 55–58, 64, 68, 72, 76, 80, 84, 88, 93, 95, 109–110
TOTAL6528586% 

Tests Skipped Failures Errors Time
84 0 💤 0 ❌ 0 🔥 2m 47s ⏱️

Copy link
Copy Markdown
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a content perspective it lgtm now barring any changes to be made as the pipeline gets built.

@nx10
Copy link
Copy Markdown
Contributor Author

nx10 commented Feb 12, 2026

I think it might be nice to add to either the readme or some page in the online docs - not sure where yet

@nx10 nx10 marked this pull request as ready for review February 12, 2026 21:00
@nx10 nx10 merged commit b116c34 into main Feb 27, 2026
7 checks passed
@nx10 nx10 deleted the pipeline-flow-figure branch February 27, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants