Feature/issue 178/build docker image#194
Merged
Merged
Conversation
Handle nonwear and threshold argument passing through docker Testing docker action
Revert back to main after test
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 13 13
Lines 778 778
=======================================
Hits 748 748
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Removed verbosity env var
frey-perez
reviewed
May 9, 2025
Small documentation changes for running a single file through docker + punctuation.
Type dependency click causing issue with cli tests for python > 3.9. Modified tests here
Move to cmidair dockerhub
Pinning 3rd party actions to commit hash of latest release
Fix typo
Reverting to run action only push to main
Fix tag
reindervdw-cmi
approved these changes
May 16, 2025
Contributor
reindervdw-cmi
left a comment
reindervdw-cmi
left a comment
There was a problem hiding this comment.
LGTM - I'd just make sure you don't include the pngs (and any other large files)
| FROM python:3.11-buster | ||
|
|
||
| WORKDIR /app | ||
| COPY . /app/ |
Contributor
There was a problem hiding this comment.
Can you make this copy more specific, or add a .dockerignore, to avoid copying unnecessary large files like the documentation pngs into the docker image?
Adding simple docker ignore to decrease docker image size
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #178
Create a docker image of the latest version of wristpy. This PR also include the github action that generates a new Docker container for the latest release (triggered on pushes to main and new version release).
We enable passing environment variables for customization of the docker run.